search

cncf / filterable-landscape

Interactive version of the Cloud Native Landscape
https://landscape.cncf.io/
Apache License 2.0
9 stars 12 forks source link

Fatal error on bad `repo_url:` #311

Closed dankohn closed 6 years ago

dankohn commented 6 years ago

Please fail with a fatal error if a repo_url value does not start with https://github.com/ and then doesn't also contain a single additional slash.

E.g., this commit should have failed for having a GitHub org instead of a repo: https://github.com/cncf/filterable-landscape/commit/a05536c7b49aeecd8e16dc05813171c386848dd8

AndreyKozlov1984 commented 6 years ago

But what about repos which are not hosted on a github ?

dankohn commented 6 years ago

We're using a mirror. I got the CEO of GitLab to set up this mirror, for example: https://landscape.cncf.io/selected=runner

-- Dan Kohn dan@linuxfoundation.org Executive Director, Cloud Native Computing Foundation https://www.cncf.io +1-415-233-1000 https://www.dankohn.com

On Tue, Feb 27, 2018 at 12:08 PM, Andrey Kozlov notifications@github.com wrote:

Closed #311 https://github.com/cncf/filterable-landscape/issues/311 via 703f59c https://github.com/cncf/filterable-landscape/commit/703f59c5f2ddbbc02b0ed43e7dc7f8c12d0295db .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cncf/filterable-landscape/issues/311#event-1494888173, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8MBiFjASe_T4s_YNHPRSfZpH2t1pStks5tZDapgaJpZM4SSqcv .