search

cncf / hugo-netlify-starter

Static website template for CNCF projects
https://cncf-hugo-starter.netlify.com/
Other
26 stars 16 forks source link

Add the responsive viewport meta tag #111

Closed nate-double-u closed 2 weeks ago

nate-double-u commented 2 years ago

Based on work by @di in the private repo https://github.com/securitysos/sos.dev (https://github.com/securitysos/sos.dev/pull/21 & https://github.com/securitysos/sos.dev/pull/22 -- since https://sos.dev is live now, I think it's OK to link to the repo)

deploy preview: https://deploy-preview-111--cncf-hugo-starter.netlify.app/

fixes #56

nate-double-u commented 2 years ago

Tested on Mobile Safari on iOS

nate-double-u commented 2 years ago

I'm thinking about citations -- in this case, would it be better to cherry pick the downstream change and commit it to this repo to keep the attribution rather than just coping the line and commenting in the PR where it came from?

di commented 2 years ago

I'm thinking about citations -- in this case, would it be better to cherry pick the downstream change and commit it to this repo to keep the attribution rather than just coping the line and commenting in the PR where it came from?

Doesn't matter to me!

nate-double-u commented 2 years ago

I'm thinking about citations -- in this case, would it be better to cherry pick the downstream change and commit it to this repo to keep the attribution rather than just coping the line and commenting in the PR where it came from?

Doesn't matter to me!

I appreciate it! Back in college citations were always so simple, citing code always feels more complicated.