search

cncf / hugo-netlify-starter

Static website template for CNCF projects
https://cncf-hugo-starter.netlify.com/
Other
26 stars 16 forks source link

Drop unneeded HUGO_VERSION from netlify.toml #68

Closed chalin closed 3 years ago

chalin commented 3 years ago

Given that this template repo uses the hugo-extended npm package, IMHO we don't need to (actually, shouldn't) specifying a Hugo version in netlify.toml:

https://github.com/cncf/hugo-netlify-starter/blob/9ce9f2d835f216db463c4872b9ddf984eb4ad42f/netlify.toml#L5-L6

Let's keep things DRY and configure the required Hugo version in only one place.

Related: #66

kapunahelewong commented 3 years ago

I can take this one. Is the task to remove just those two lines from netlify.toml?

chalin commented 3 years ago

Actually, let me test something first before we start on this.

chalin commented 3 years ago

Check complete: I wanted to ensure that there weren't going to be any problems with running the npm-fetched Hugo under macOS 10.15+. There are not permissions issues.

I can take this one.

Thanks!

Is the task to remove just those two lines from netlify.toml?

And anywhere else that a Hugo version might be mentioned -- e.g., the README file.

chalin commented 3 years ago

You might want to tackle #66 at the same time, or not. It's your call.

chalin commented 3 years ago

And anywhere else that a Hugo version might be mentioned -- e.g., the README file.

If you just want to update the netlify.toml file for this issue, that'll be fine too.

chalin commented 3 years ago

Oh, I just remembered that if we use the npm-installed version of hugo, then you'll need to update the Makefile to use npx hugo everywhere a plain hugo is currently written.