cncf / hugo-netlify-starter

Static website template for CNCF projects
https://cncf-hugo-starter.netlify.com/
Other
26 stars 16 forks source link

Add responsive styles, search, example docs structure #73

Closed kapunahelewong closed 2 years ago

kapunahelewong commented 2 years ago

Signed-off-by: Kapunahele Wong kapunahelewong@gmail.com

Responsive updates (320px & up)

Update styles

Also adds placeholder responsive Programmable Google Search.

cc @caniszczyk @celestehorgan

kapunahelewong commented 2 years ago

Preview: https://deploy-preview-73--cncf-hugo-starter.netlify.app/

To see responsive updates, resize the browser window.

nate-double-u commented 2 years ago

There are some great changes here, thanks @kapunahelewong

My only comment on a quick once over is that the Jumbotron on the front page is lined up with the logo rather than the content. I think this is because there may be a left side menu present on other pages that also lines up with the logo, but it looks a little off with out it (IMO). A potential fix (aside from moving the Jumbotron text right) may be to align the footer (left justify rather than centred) with the logo and jumbotron on the top.

Screen Shot 2021-07-22 at 3 07 22 PM

kapunahelewong commented 2 years ago

My only comment on a quick once over is that the Jumbotron on the front page is lined up with the logo rather than the content.

Thanks for catching that, @nate-double-u! It was a Bootstrap media query applying via a rogue class only to that middle section. Everything should be aligned now.

celestehorgan commented 2 years ago

@kapunahelewong awesome! Update the branch so we can merge, and otherwise this LGTM

kapunahelewong commented 2 years ago

Rebased and pushed. Thank you, @celestehorgan!