fix white space around links

cncf / hugo-netlify-starter

Static website template for CNCF projects

https://cncf-hugo-starter.netlify.com/

Other

26 stars 16 forks source link

fix white space around links #93

Closed kapunahelewong closed 2 years ago

kapunahelewong commented 2 years ago

This PR is a work in progress trying to fix the extra space that appears around links:

kapunahelewong commented 2 years ago

Preview: https://deploy-preview-93--cncf-hugo-starter.netlify.app/

kapunahelewong commented 2 years ago

Oooh that worked perfectly. Thank you @chalin!!

nate-double-u commented 2 years ago

LGTM (though I'm not sure what your last commit changed relative to earlier).

I had the same thing over on #86, the GitHub UI said the branch was out of date with main, but I didn't see how. Rebasing and force-pushing seems to have sorted it (but wipes out approvals)

chalin commented 2 years ago

Anything left to do here before this is merged @kapunahelewong? If not, please do the following:

Add "Closes #45" to the opening comment if you believe that it closes the issue. (This will allow GitHub to close the issue once this PR is merged.)
Go ahead an "squash 'n merge" this PR. (Generally, once you have received the necessary approvals for a PR, feel free to merge it.)

chalin commented 2 years ago

Oops, @nate-double-u, beat you to it. Well, for next time then :).

nate-double-u commented 2 years ago

(sorry, I merged it literally the same moment you posted that. I did link the issue before I did so 😅)