cncf / landscape

🌄 The Cloud Native Interactive Landscape filters and sorts hundreds of projects and products, and shows details including GitHub stars, funding, first and last commits, contributor counts and headquarters location.
https://l.cncf.io
Apache License 2.0
9.22k stars 1.92k forks source link

Add OpenLIT to CNCF and CNAI Landscape #3895

Closed patcher9 closed 1 month ago

patcher9 commented 1 month ago

Pre-submission checklist:

Please check each of these after submitting your pull request:

github-actions[bot] commented 1 month ago

You can preview your changes by visiting this link.

[!NOTE] This feature is still experimental and may not work as expected in some cases. Please report any issues you find!

tegioz commented 1 month ago

Hi @patcher9

We've just updated the landscape.yml file validation process to allow using the x.com domain in Twitter urls 🙂 (we saw that this raised an error in your previous PR)

patcher9 commented 1 month ago

Thanks @tegioz Just changed now to x.com

tegioz commented 1 month ago

No worries! I'll deploy it shortly, please leave it with the x.com domain 😉

tegioz commented 1 month ago

Done! The preview should not complain about the invalid Twitter url anymore.

patcher9 commented 1 month ago

Yup works great now, Thanks @tegioz

patcher9 commented 1 month ago

Hey @tegioz who can I ping for a review on this? and do you know why the validate landscape.yml file Expected — Waiting for status to be reported is not running?

tegioz commented 1 month ago

Hi @patcher9

A teammate will review it soon, don't worry 🙂

Regarding the validation check question: the workflow needs to be approved first by a maintainer. But this validation is also done during the preview setup, so you should be fine. It's just some extra precaution so that changes that break the data file cannot be committed.