Closed patcher9 closed 1 month ago
You can preview your changes by visiting this link.
[!NOTE] This feature is still experimental and may not work as expected in some cases. Please report any issues you find!
Hi @patcher9
We've just updated the landscape.yml
file validation process to allow using the x.com
domain in Twitter urls 🙂 (we saw that this raised an error in your previous PR)
Thanks @tegioz
Just changed now to x.com
No worries! I'll deploy it shortly, please leave it with the x.com
domain 😉
Done! The preview should not complain about the invalid Twitter url anymore.
Yup works great now, Thanks @tegioz
Hey @tegioz who can I ping for a review on this?
and do you know why the validate landscape.yml file Expected — Waiting for status to be reported
is not running?
Hi @patcher9
A teammate will review it soon, don't worry 🙂
Regarding the validation check question: the workflow needs to be approved first by a maintainer. But this validation is also done during the preview setup, so you should be fine. It's just some extra precaution so that changes that break the data file cannot be committed.
Pre-submission checklist:
Please check each of these after submitting your pull request:
repo_url
if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.hosted_logos
and referenced it there?