Incorrect `good-first-issues` hyperlink in the Project Jupyter overlay

[Haleshot]

Found an incorrect hyperlink being listed in the Project Jupyter overlay. The link is - https://landscape.cncf.io/?item=cnai--data-science--project-jupyter. Screenshot for reference:

The hyperlink (when hovering over the badge) points to - https://github.com/jupyter/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22; the /jupyter after jupyter is missing (to point to the repo).

However. such a label does not exist in the repo; found other such tools (in overlays) where this is an issue too. Could not see this (incorrect hyperlink) being listed in the landscape.yml file.

Should I add to this issue to make it more comprehensive in terms of issues relating to these things (overlays having incorrect hyperlinks, outdated badges, etc.)?

[tegioz]

Hi @Haleshot 👋

The repo_url field in the Jupyter landscape entry doesn't seem to be valid (it's missing a /jupyter part as you mentioned). The good first issues badge link is built from it, that's why it's not working fine. We also use that repository url to collect some information from GitHub and display some stats in that view (that are also missing at the moment).

A PR to fix it would be welcome if you are interested 🙂

https://github.com/cncf/landscape/blob/a59c67ff3e471d1347dfde01c31706524f66429a/landscape.yml#L18917-L18924

[rahulmansharamani14]

Hi @tegioz, Is there anyone working on this? If not, I'd like to give it a try.

[tegioz]

Hi @rahulmansharamani14

Not that I'm aware of, please go ahead 🙂

[rahulmansharamani14]

Hi @tegioz, I've opened a PR to fix this issue and confirmed the change in the preview environment (attaching the screenshot). (PR #4156)

[tegioz]

Awesome, thanks!

[Haleshot]

Ah, didn't see this notification pop up earlier (in my email feed); great that this issue is resolved now. Thanks @rahulmansharamani14, @tegioz

[tegioz]

Closed by #4156