search

cncf / landscapeapp

🌄Upstream landscape generation application
https://landscapes.dev/
Apache License 2.0
253 stars 124 forks source link

Acquisition data should be used for determining sub-organizations #307

Closed jmertic closed 4 years ago

jmertic commented 4 years ago

Example:

https://www.crunchbase.com/organization/the-walt-disney-company

All of Disney's acquisitions aren't listed as sub-organizations, so when looking for member projects we miss the acquisition's projects. Right now I can hack around this with the members.yml file, but that's going away ( https://github.com/cncf/landscapeapp/issues/260 ).

jmertic commented 4 years ago

Note it's currently working in the ASWF Landscape, but that's because I've added the acquired organizations manually to the members.yml file. Once that file goes away, this will be broken.

AndreyKozlov1984 commented 4 years ago

@dankohn does this mean I need to treat every sub-organization as a root organization when deciding about membership? @jmertic any chance to provide a single example ?

dankohn commented 4 years ago

Treat an organization as a member if either it is a member or its parent from Crunchbase is a member.

Please create a fork of https://github.com/AcademySoftwareFoundation/aswf-landscape where you remove members.yml. Then, https://landscape.aswf.io/format=card-mode&selected=open-subdiv should still be a member project because Pixar's parent is Disney, and Disney is a member.

AndreyKozlov1984 commented 4 years ago

Looks good, except one thing - there is a https://www.crunchbase.com/organization/the-walt-disney-company#section-overview which has all the acquisitions, but somehow the crunchbase used in the old members.yml is https://www.crunchbase.com/organization/walt-disney-studios which is different and has zero acquisitions. Can I use https://www.crunchbase.com/organization/the-walt-disney-company , @jmertic ?

dankohn commented 4 years ago

Yes, fine to switch. But, ideally, if walt-disney-studios were set as a subsidiary of walt-disney-company, you would be able to see that pixar is a member if they share a parent.

Cc @jmertic

jmertic commented 4 years ago

Agreed - thanks @ZeusTheTrueGod.

AndreyKozlov1984 commented 4 years ago

Does this mean I need to go the parent as much as possible, and then check all acquisitions? Whatever, that logic seems to be too complex, I've just added a check for a company acquisitions.

AndreyKozlov1984 commented 4 years ago

https://5d6992eb640e0f000c9fbc8d--landscapeapp.netlify.com/aswf/selected=usd-universal-scene-description

@jmertic @dankohn please check, I think now it works there

dankohn commented 4 years ago

It looks correct to me. We can merge and see if this fixes the problem, if you're OK.

AndreyKozlov1984 commented 4 years ago

@jmertic that was merged in #260