cncf / landscapeapp

🌄Upstream landscape generation application
https://landscapes.dev/
Apache License 2.0
255 stars 125 forks source link

Crunchbase requirement is too strict #767

Closed nicorikken closed 3 years ago

nicorikken commented 3 years ago

I'm trying to add pandapower to the LFEnergy landscape (pull request: https://github.com/lf-energy/lfenergy-landscape/pull/293). As the majority of the code is developed in tandem between the University of Kassel and Fraunhofer Institute for for Energy Economics and Energy System Technology (IEE) Kassel, there is no single entity to attribute in the Crunchbase field. I tried leaving it out or leaving it empty, but that fails. I can provide a single entry, but that doesn't do justice to the other party.

I believing making this field mandatory and single-entry is a mistake that needs to be addressed. I think the most pragmatic solution is to allow omitting the field or setting an explicit None value.

caniszczyk commented 3 years ago

I would just pick one, someone always owns the IP behind the code. Who started the project? First commit?

On Tue, Aug 31, 2021 at 6:33 AM Nico Rikken @.***> wrote:

I'm trying to add pandapower http://www.pandapower.org/ to the LFEnergy landscape https://landscape.lfenergy.org/ (pull request: lf-energy/lfenergy-landscape#293 https://github.com/lf-energy/lfenergy-landscape/pull/293). As the majority of the code is developed in tandem between the University of Kassel and Fraunhofer Institute for for Energy Economics and Energy System Technology (IEE) Kassel, there is no single entity to attribute in the Crunchbase field. I tried leaving it out or leaving it empty, but that fails. I can provide a single entry, but that doesn't do justice to the other party.

I believing making this field mandatory and single-entry is a mistake that needs to be addressed. I think the most pragmatic solution is to allow omitting the field or setting an explicit None value.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIJSU44FRCLQFISGGJ3T7S4YPANCNFSM5DD47LZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

jordinl commented 3 years ago

@nicorikken instead of having to add a crunchbase entry you can use

organization:
  name: Some organization in tandem with some other organization
nicorikken commented 3 years ago

Thanks @jordinl83 that worked!