search

cncf / landscapeapp

🌄Upstream landscape generation application
https://landscapes.dev/
Apache License 2.0
255 stars 125 forks source link

[feature] 'openssf.html' that lists if CNCF projects have an OpenSSF/CII badge #798

Closed caniszczyk closed 2 years ago

caniszczyk commented 2 years ago

There are a couple fund CNCF landscape features like /acquisitions and /funding.html, I'd love for us to build something that essentially is able to list all projects in CNCF (or other landscapes) that have an OpenSSF/CII badge, this is already built into the landscape itself in the detailed view:

Screen Shot 2022-01-19 at 10 57 31 AM

I'd ideally like to have a l.cncf.io/openssf.html style URL that shows all the projects that have passing badges and ones that don't

idvoretskyi commented 2 years ago

/cc @idvoretskyi

AndreyKozlov1984 commented 2 years ago

Let me review, we had a flag for that to list all the projects with passing CII best practices in a cards mode, just that flag is not present in a user interface in the filters section.

Also we have aliases for pages with given filters. I'll ensure that there is a filter for those projects Plus I'll add a default openssf-passing.html for those projects which pass the CCI Best Practices check and openssf-missing.html for all the remaining

caniszczyk commented 2 years ago

Thanks, appreciate it :)

On Wed, Jan 19, 2022 at 3:39 PM Andrey Kozlov @.***> wrote:

Let me review, we had a flag for that to list all the projects with passing CII best practices in a cards mode, just that flag is not present in a user interface in the filters section.

Also we have aliases for pages with given filters. I'll ensure that there is a filter for those projects Plus I'll add a default openssf-passing.html for those projects which pass the CCI Best Practices check and openssf-missing.html for all the remaining

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/798#issuecomment-1016891140, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIN6HYOLUFQATYY7YZ3UW4VQPANCNFSM5MKPB57A . You are receiving this because you authored the thread.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

AndreyKozlov1984 commented 2 years ago

https://landscape.cncf.io/card-mode?bestpractices=yes https://landscape.cncf.io/card-mode?bestpractices=no

Adjusting these urls now to match exactly for "100%" instead of any percentage. And adding openssf-passing together with openssf-missing by default!

jordinl commented 2 years ago

Do I still need to build a separate page or does the solution above suffice?

AndreyKozlov1984 commented 2 years ago

I am going to add those defaults pages for all landscapes as openssf-passing and openssf-failing. Waiting for @caniszczyk if https://landscape.cncf.io/card-mode?bestpractices=yes https://landscape.cncf.io/card-mode?bestpractices=no is enough or if he needs a different way to represent items in the list

caniszczyk commented 2 years ago

Andrey's solution is enough, thank you!!!!!!

On Thu, Jan 20, 2022 at 8:38 AM Andrey Kozlov @.***> wrote:

I am going to add those defaults pages for all landscapes as openssf-passing and openssf-failing. Waiting for @caniszczyk https://github.com/caniszczyk if https://landscape.cncf.io/card-mode?bestpractices=yes https://landscape.cncf.io/card-mode?bestpractices=no is enough or if he needs a different way to represent items in the list

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/798#issuecomment-1017575688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIIXKL5KDVLGYEUF6ATUXAM6ZANCNFSM5MKPB57A . You are receiving this because you were mentioned.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

idvoretskyi commented 2 years ago

Fantastic, thanks @AndreyKozlov1984!

caniszczyk commented 2 years ago

actually, can we have sandbox projects also come up here? https://landscape.cncf.io/card-mode?bestpractices=no

On Thu, Jan 20, 2022 at 8:42 AM Ihor Dvoretskyi @.***> wrote:

Fantastic, thanks @AndreyKozlov1984 https://github.com/AndreyKozlov1984!

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/798#issuecomment-1017579401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIPUQPOUTCG2264KLRTUXANNVANCNFSM5MKPB57A . You are receiving this because you were mentioned.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

AndreyKozlov1984 commented 2 years ago

They are already there, just too many items! https://landscape.cncf.io/card-mode?bestpractices=no&project=sandbox

this one has only sandbox projects with bestpractices !== 'passing'

caniszczyk commented 2 years ago

thanks, this is beautiful and I'm happy with the feature

maybe we can add this as an example filter, "Cards without bestpractices.dev "

On Thu, Jan 20, 2022 at 8:50 AM Andrey Kozlov @.***> wrote:

They are already there, just too many items! https://landscape.cncf.io/card-mode?bestpractices=no&project=sandbox

this one has only sandbox projects with bestpractices !== 'passing'

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/798#issuecomment-1017586750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIOTJWWAIHC5LTDLOKLUXAOLXANCNFSM5MKPB57A . You are receiving this because you were mentioned.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

AndreyKozlov1984 commented 2 years ago

https://landscape.cncf.io/card-mode?bestpractices=no That filter? Not sandbox specific? Ok, let me add it to the CNCF landscape!

caniszczyk commented 2 years ago

Thanks, yes, that filter, INCLUDING sandbox projects would be great

On Thu, Jan 20, 2022 at 8:54 AM Andrey Kozlov @.***> wrote:

https://landscape.cncf.io/card-mode?bestpractices=no That filter? Not sandbox specific? Ok, let me add it to the CNCF landscape!

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/798#issuecomment-1017590111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIOH5KDNLWLYQJXQSPDUXAOYXANCNFSM5MKPB57A . You are receiving this because you were mentioned.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

caniszczyk commented 2 years ago

Andrey, when will the feature work in other landscapes ;)? https://landscape.cd.foundation/card-mode?bestpractices=no

On Thu, Jan 20, 2022 at 8:55 AM Chris Aniszczyk @.***> wrote:

Thanks, yes, that filter, INCLUDING sandbox projects would be great

On Thu, Jan 20, 2022 at 8:54 AM Andrey Kozlov @.***> wrote:

https://landscape.cncf.io/card-mode?bestpractices=no That filter? Not sandbox specific? Ok, let me add it to the CNCF landscape!

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/798#issuecomment-1017590111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIOH5KDNLWLYQJXQSPDUXAOYXANCNFSM5MKPB57A . You are receiving this because you were mentioned.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

AndreyKozlov1984 commented 2 years ago

This link works properly on all the landscapes. 'yes' means 'passing', 'no' means any other status or lack of it completely.

caniszczyk commented 2 years ago

got it, thanks

On Thu, Jan 20, 2022 at 9:08 AM Andrey Kozlov @.***> wrote:

This link works properly on all the landscapes. yes means 'passing', no means any other status or lack of it completely.

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/798#issuecomment-1017604352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIN26Q52HBKHPFFFMHTUXAQQFANCNFSM5MKPB57A . You are receiving this because you were mentioned.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

AndreyKozlov1984 commented 2 years ago

I've added a filter to CNCF - image

caniszczyk commented 2 years ago

thanks!

On Thu, Jan 20, 2022 at 9:22 AM Andrey Kozlov @.***> wrote:

I've added a filter to CNCF - [image: image] https://user-images.githubusercontent.com/230982/150368116-faf10417-4762-4126-b0cf-2c06efee9dc6.png

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/798#issuecomment-1017618353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIKXUBITYTUJ67SKECLUXASFFANCNFSM5MKPB57A . You are receiving this because you were mentioned.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

caniszczyk commented 2 years ago

LGTM, maybe some small issues to resolve but this is a great feature, thank you!