search

cncf / landscapeapp

🌄Upstream landscape generation application
https://landscapes.dev/
Apache License 2.0
255 stars 125 forks source link

addExternalInfo: Correctly reuse cached crunchbase info #836

Open danielsilverstone-ct opened 2 years ago

danielsilverstone-ct commented 2 years ago

When a crunchbase key is not in the environment; but the settings request crunchbase data, we should reuse the data from the processed landscape file.

This fixes #835

netlify[bot] commented 2 years ago

Deploy Preview for landscapeapp ready!

Name Link
Latest commit 957a4e113c5e043818389ff565ef5f0eb150009b
Latest deploy log https://app.netlify.com/sites/landscapeapp/deploys/62de6e6aed5f6e00081fbc02
Deploy Preview https://deploy-preview-836--landscapeapp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

milanlakhani commented 2 years ago

This works for me.

AndreyKozlov1984 commented 2 years ago

global.skip_crunchbase

danielsilverstone-ct commented 2 years ago

global.skip_crunchbase

This breaks landscapes which are designed to consume crunchbase data (such as the CNCF one) - it is clearly a bug that the cached crunchbase data was not being used as evidenced by the message: CRUNCHBASE_KEY_4 is not set. Using processed_landscape.yml as a source for crunchbase info which was emitted even though the info was then promptly deleted from the processed landscape.