cncf / landscapeapp

🌄Upstream landscape generation application
https://landscapes.dev/
Apache License 2.0
255 stars 125 forks source link

Add a11y support to the landscape #842

Open juliaferraioli opened 2 years ago

juliaferraioli commented 2 years ago

All landscapes are lacking accessibility support, including but not limited to:

A basic lighthouse audit gives landscapes a sub-60 score.

awright commented 2 years ago

i'd also love to see this prioritized. the idea of a landscape is very powerful and i'd love if the breadth of our landscapes could be accessible to as many as possible.

AndreyKozlov1984 commented 2 years ago

I think that is fixed, at least the alt text

caniszczyk commented 2 years ago

Yes, can you link to the commits?

I think we can link to an a11y test showing decent results and continue to iterate and improve

On Thu, Sep 29, 2022 at 3:46 PM Andrey Kozlov @.***> wrote:

I think that is fixed, at least the alt text

— Reply to this email directly, view it on GitHub https://github.com/cncf/landscapeapp/issues/842#issuecomment-1262796355, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPSIPA334PZRM73RFLZFLWAX5ZDANCNFSM6AAAAAAQMGUO74 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Cheers,

Chris Aniszczyk https://aniszczyk.org

awright commented 2 years ago

that would be great. and great for our internal discussions too. many thanks!

juliaferraioli commented 2 years ago

Adding alt text without fixing keyboard navigation doesn't do much, unfortunately. The contrast on the text within the tiles, which actually contains the information, is the thing that can be addressed independently. While the WebAIM contrast checker indicates that it may pass in some situations, at the size of the text involved it fails AAA.

Additionally, the alt text only works on card mode. For landscape mode, the alt text is insufficient. See the functional images guidance.