cncf / landscapeapp

🌄Upstream landscape generation application
https://landscapes.dev/
Apache License 2.0
255 stars 125 forks source link

Allow fields to include labelled hyperlinks and be split into sections #851

Open milanlakhani opened 2 years ago

milanlakhani commented 2 years ago

This enhances the look of fields in the item dialog boxes in two ways - enabling labelled hyperlinks and adding sections.

The labelled hyperlinks change allows extra fields in landscape.yml to have text values that link to a url that is not the same as the text. To add a labelled hyperlink, the syntax to use is <label>(hyperlink) (so same as markdown syntax except <> instead of [] )

The sections change adds an optional config in settings.yml, which can put the 'extra' fields in an item's dialog box into sections to improve the appearance.

Needless to

This is what the item detail box looks like with and without sections: Without:

Screenshot 2022-08-04 at 14 37 03

With:

Screenshot 2022-08-04 at 15 34 17

The placement of the optional sections config in settings.yml is as follows:

big_picture:
  main:
    sections:
      - name: Section1 name
        children:
           - Key1 name in section
           - Key2 name in section
      - name : Section2 name
        children:
          ...

CC @michaelmoss @awright @GeriG966 @danielsilverstone-ct @abhi0469

netlify[bot] commented 2 years ago

Deploy Preview for landscapeapp ready!

Name Link
Latest commit 9eaf37781357b2a256bc015873442aaf0ae0a6c3
Latest deploy log https://app.netlify.com/sites/landscapeapp/deploys/63740c76c137f80008ab294e
Deploy Preview https://deploy-preview-851--landscapeapp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

milanlakhani commented 1 year ago

Hi @AndreyKozlov1984 , I'm back from my holiday now, hope you are well. Feel free to let me know any improvements that I can make if it would help :)

AndreyKozlov1984 commented 1 year ago

@milanlakhani That is too much change, and it requires serious changes in the format. Ideally the format should be same as before, let me think a bit what we can afford