Closed aliok closed 1 year ago
riaankleinhans
commented
1 year ago @aliok This great work. I see a few things that I would surgest changes for. Would be easier to collaberate on a google doc and copy the results back to the PR. What do you think @nate-double-u ?
nate-double-u
commented
1 year ago Would be easier to collaberate on a google doc and copy the results back to the PR. What do you think @nate-double-u ?
At this point it's probably best to have the discussion in public -- I'm a fan of drafting PRs in google docs or in hackmd, but once the PR is made then splitting the conversation around edits and suggestions can make things harder.
The GitHub UI does allow for suggestions to be applied across multiples lines, which makes comments on large PRs like this a little easier.
aliok
commented
1 year ago Created https://docs.google.com/document/d/1Zozg3g5qE4jkdVEdiVtCoXvc_iuuOls1hfCgW6Pf7jQ/edit?usp=sharing
Closing this PR now. Let's collaborate on the Google Doc and I will create a new PR later.
Fixes https://github.com/cncf/mentoring/issues/736
cc @Riaankl I see there's more in https://github.com/cncf/mentoring/issues/736 like instructions about program specific things, but I didn't write them. ...well, I can't write them anyway as I don't know how the platforms work other than GSoC.
IMO, we should keep our mentor guide generic. Platform related instructions are sent with each announcement anyway (like, "It is time to review mentee applications. Use this page / that form to inform us with your selection", etc.)