search

cncf / mentoring

👩🏿‍🎓👨🏽‍🎓👩🏻‍🎓CNCF Mentoring: LFX Mentorship + Summer of Code
https://mentoring.cncf.io
Apache License 2.0
2.3k stars 600 forks source link

Corrected spelling mistakes #1091

Closed ravixis29 closed 9 months ago

ravixis29 commented 9 months ago

<Signed-off-by: Ravi Kumar ravixis29@gmail.com>

aliok commented 9 months ago

@ravixis29 Thanks for the PR, looks great.

Can you amend your commit to make sure it is signed off?

git commit --amend --signoff
ravixis29 commented 9 months ago

I have signed off it. Kindly check and confirm @aliok

nate-double-u commented 9 months ago

Before we merge this, we still need you to sign off on the commits. You can find instructions here: https://github.com/cncf/mentoring/pull/1091/checks?check_run_id=17111169388

I see that you did sign off, but the settings still aren't quite correct, see the last line from the link above:

Commit sha: f9e74eb, Author: ravixis29@gmail.com, Committer: ravixis29@gmail.com; Expected "ravixis29@gmail.com ravixis29@gmail.com", but got "Ravi Kumar ravixis29@gmail.com".

nate-double-u commented 9 months ago

Thanks for making the update!