cncf / mentoring

👩🏿‍🎓👨🏽‍🎓👩🏻‍🎓CNCF Mentoring: LFX Mentorship + Summer of Code
https://mentoring.cncf.io
Apache License 2.0
2.29k stars 600 forks source link

Add Image Signing From K8s RelEng #1230

Closed puerco closed 1 month ago

puerco commented 1 month ago

This commit adds to the project ideas a proposal from Kubernetes Release Engineering. We are seeking help to fix image signatures in our image promotion process.

/hold For final RelEng review /cc @mehabhalodiya

mehabhalodiya commented 1 month ago

+1, I'm in support of this.

cc @nate-double-u @aliok

puerco commented 1 month ago

@nate-double-u @aliok is it possible to add more than one two mentors? This project will likely require more than the two of us.

aliok commented 1 month ago

@puerco add as many as you like! We're ready to merge this one, but I am waiting for you to update the PR with new mentors.

mehabhalodiya commented 1 month ago

@puerco Please add @xmudrii to the mentor's list. He will be going to help as much as he can without a doubt and he also confirmed that he'll have plenty of time capacity for image promoter work. 🙂 Thank you!

puerco commented 1 month ago

OK, I've added @xmudrii and @jeremyrickard to the list of mentors

jeremyrickard commented 1 month ago

+1 from me with SIG Release Chair Hat on

puerco commented 1 month ago

OK, I stupidly added /hold to note that we were still working on it not realizing we don't have prow here, sorry about that!@ :upside_down_face:

@aliok we're ready to go with this one, we discussed the proposal and plan on the SIG Release meeting on May 7th and we're on.

nate-double-u commented 1 month ago

Since this is a proposal for a Kubernetes project, I think we'll need the sig-contribex leads approval as well. Usually we'd require a project maintainer's approval, but things are a touch different with K8s projects and subprojects. @kaslin & @palnabarun, if you could both take a look.

(Not to put one SIG over another, mentorship is SIG Contribex's area, and I want to make sure there's no inadvertent overlap)

justaugustus commented 1 month ago

Another SIG Release Chair +1 from me!

nate-double-u commented 1 month ago

OK, I stupidly added /hold to note that we were still working on it not realizing we don't have prow here, sorry about that!@ 🙃

I do the same thing 😂

aliok commented 1 month ago

Thanks folks!

kaslin commented 1 month ago

Oops, we never did respond here. I don't think SIG ContribEx approval is explicitly required, but as long as the folks running it believe it makes sense and are excited to do it, we're happy to offer our approval!

kaslin commented 1 month ago

We do also appreciate being involved so we can try to keep track of mentoring efforts going on in the project, so maybe requiring SIG ContribEx approval is the way to achieve that.