Closed XiShanYongYe-Chang closed 3 months ago
/cc @RainbowMango
Thanks for this @XiShanYongYe-Chang, i see your hold and will remove the label when you're ready.
Also, we've extended the proposal window, project proposals are now due July 30, 2024 (https://github.com/cncf/mentoring/discussions/1263)
Thanks a lot @nate-double-u It's ready now. /hold-cancel
/hold cancel
/remove-hold
Hi @nate-double-u I have fixed the merge conflict, and I am trying to remove the hold label, but it didn't success. Can you help me remove the hold label? Thanks~
hi @XiShanYongYe-Chang
I removed the hold now. After merging another PR, there's a new conflict which I will resolve in a moment.
We need approval / 👍 from a person listed in the maintainers list for Karmada: https://raw.githubusercontent.com/cncf/foundation/main/project-maintainers.csv
Thanks @aliok
/assign @RainbowMango
Hi @nate-double-u I have fixed the merge conflict, and I am trying to remove the hold label, but it didn't success. Can you help me remove the hold label? Thanks~
Sorry, it's not an automatic system 😅
Thanks @XiShanYongYe-Chang for submitting this and thanks to @aliok @nate-double-u for the help.
@warjiang and @zhzhuang-zju
Can you give us 👍 please?
Then we can merge.
Hi, I'm still looking for a 👍 or approval from @zhzhuang-zju to confirm their participation before we can merge this in.
The PR was opened before the due date, so don't worry about not getting this merged before today. Even if it's a couple days late we can load this into the LFX platform but it may have to go in on the second pass (which means it may miss being available for the first day or 2 of candidate applications).
@XiShanYongYe-Chang, could you remove the files in the .idea
folder?
I see we have a 👍 from @zhzhuang-zju, so we can merge this as soon as we remove the .idea
folder files.
could you remove the files in the
.idea
folder?
I'm sorry, I just see it, Thanks a lot @nate-double-u
/hold