cncf / mentoring

πŸ‘©πŸΏβ€πŸŽ“πŸ‘¨πŸ½β€πŸŽ“πŸ‘©πŸ»β€πŸŽ“CNCF Mentoring: LFX Mentorship + Summer of Code
https://mentoring.cncf.io
Apache License 2.0
2.4k stars 614 forks source link

pod lifecycle events project #1279

Closed SergeyKanzhelev closed 3 months ago

SergeyKanzhelev commented 4 months ago

xlink: https://github.com/kubernetes/kubernetes/issues/126369

I will try to find out if anybody from SIG Docs can help. I have limited knowledge of hugo and automation possible on website.

satyampsoni commented 3 months ago

I think @sftim @nate-double-u or @divya-mohan0209 can help.

nate-double-u commented 3 months ago

Hi @SergeyKanzhelev, thanks for this!

Since this is a proposal for a Kubernetes project, we'll also need the approval of the sig-contribex leads. Usually, we'd require a project maintainer's approval, but things are a bit different with K8s projects and subprojects. I believe the chairs are currently: @kaslin & @palnabarun, if you could both take a look πŸ™‚

I'd also like to wait for the upstream issue to get triaged before we accept this (I expect this is part of why this is a WIP proposal πŸ™‚).

When it comes time, could @tallclair provide a πŸ‘ or approve this PR to confirm participation?

SergeyKanzhelev commented 3 months ago

/assign @tallclair

@nate-double-u definitely will contact contribex leads, I was not sure what the process is =).

kaslin commented 3 months ago

Within Kubernetes, we don't require any review @nate-double-u. We confirmed this in slack with a past project lead and our mentoring subproject lead (@jberkus). That said, we're happy to review if folks want us to.

kaslin commented 3 months ago

Looks Good to Me πŸ‘

nate-double-u commented 3 months ago

Within Kubernetes, we don't require any review @nate-double-u. We confirmed this in slack with a past project lead and our mentoring subproject lead (@jberkus). That said, we're happy to review if folks want us to.

The request is more for the CNCF mentorship adminsβ€”usually, we require a maintainer to approve an LFX mentorship proposal before accepting it. In the case of Kubernetes, the project structure is much more complex, so we landed on asking for sig-contribex chairs to play the approver role. It's a way of confirming that the project approves of the work being done (and, by extension, agrees that the money spent would be worthwhile).

So, I very much appreciate you doing the reviews!

jberkus commented 3 months ago

/approve

nate-double-u commented 3 months ago

This is still set to WIP, and I'm still looking for a πŸ‘ or approval from @tallclair to confirm their participation.

The PR was opened before the due date, so don't worry about not getting this merged before today. Even if it's a couple days late we can load this into the LFX platform but it may have to go in on the second pass (which means it may miss being available for the first day or 2 of candidate applications).

SergeyKanzhelev commented 3 months ago

This is still set to WIP, and I'm still looking for a πŸ‘ or approval from @tallclair to confirm their participation.

@tallclair is out of office till Monday, but I promise he signed up for this with me. I don't want to expose Tim's email without his confirmation. Would it be ok to keep it as TODO till Monday?

nate-double-u commented 3 months ago

Monday is OK.

tallclair commented 3 months ago

Sorry for the delay. Yes, Sergey and I discussed this offline. :+1: from me.

SergeyKanzhelev commented 3 months ago

@nate-double-u this is ready to be merged