search

cncf / tag-app-delivery

📨🚚CNCF App Delivery TAG
https://tag-app-delivery.cncf.io
Apache License 2.0
788 stars 205 forks source link

Bug within website partial "page-meta-links": "Edit this page" doesn't work for pages using symlinks #393

Open niklasbeinghaus opened 1 year ago

niklasbeinghaus commented 1 year ago

Currently, pages that are using symlinks during buildtime refer to a non-existing file in the git-repository which leads to 404 File not Found errors.

"Edit this Page" link in the top right corner on these pages:

In my opinion, we should improve User Experience by either fixing the link or changing it to something more helpful.

niklasbeinghaus commented 1 year ago

I'm not a UX-Expert, however I'm also not sure how helpful the link is at all? What do we want to achieve with it? Contributions? If so, wouldn't it be easier to link to contribution guidelines?

https://github.com/cncf/tag-app-delivery/pull/392

joshgav commented 1 year ago

Thanks for discovering and telling us about this @niklasbeinghaus! I like your suggestions, need to look into how to customize that link.

@cjyabraham do you have ideas?

cjyabraham commented 1 year ago

Do you want to encourage or discourage people from proposing edits to a live whitepaper? If it's the former, perhaps we include the GH url of the page in its frontmatter and use that for the edit link? If it's the latter, possibly we just hide the edit link when nested in the whitepapers directory?

joshgav commented 1 year ago

We've heard this is a known bug, but @lianmakesthings can you please take a look? Thanks!