search

cncf / tag-app-delivery

📨🚚CNCF App Delivery TAG
https://tag-app-delivery.cncf.io
Apache License 2.0
788 stars 205 forks source link

Enable i18n with pt-br(Portuguese) for website #737

Open juliafmorgado opened 3 months ago

juliafmorgado commented 3 months ago

This PR makes Portuguese available in the language selection menu.

Translated Pages for Review:

Additional Translations (as per #612):

This is the first step to complete https://github.com/cncf/tag-app-delivery/issues/736

netlify[bot] commented 3 months ago

Deploy Preview for tag-app-delivery ready!

Name Link
Latest commit 33f1376359c6e22613c43ace330803ba51dbc946
Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/66cde7bb3109b100082ccf21
Deploy Preview https://deploy-preview-737--tag-app-delivery.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

abangser commented 3 months ago

Hey @juliafmorgado thanks so much for taking the time on this PR!

We will need to do a code/design review, but also need at least one more native speaker review. Do you have anyone in mind that can do the review? If not we can ask around and try to find someone!

juliafmorgado commented 3 months ago

Hey @abangser, @julialamenza mentioned she can review it. Do you need additional reviewers?

Thanks!

abangser commented 3 months ago

Nope, that'll do! I'll try and do the technical review this weekend so that we don't block you 🙌

juliafmorgado commented 3 months ago

Thanks @abangser! Regarding the language code, I followed what was written in the Kubernetes website documentation https://kubernetes.io/docs/contribute/localization/#find-your-two-letter-language-code

abangser commented 2 months ago

Hey @juliafmorgado just wanted to touch base around the review for this PR. I believe we are waiting for a native speaker review. Is that your understanding? Anything I can do to help?