search

cncf / tag-security

🔐CNCF Security Technical Advisory Group -- secure access, policy control, privacy, auditing, explainability and more!
https://cncf.io/projects
Other
1.99k stars 496 forks source link

OpenFGA Project security self-assessment update #1235

Closed lj365 closed 3 months ago

lj365 commented 3 months ago

Basic Threat Landscape Secure Development Practices improved with status badges all-around fixes

netlify[bot] commented 3 months ago

Deploy Preview for tag-security canceled.

Name Link
Latest commit dac97b0a3a32d98350b7433aa832a7972b3f2e18
Latest deploy log https://app.netlify.com/sites/tag-security/deploys/65fcf0cd9fa3fc00071afbd9
JustinCappos commented 3 months ago

Can you fix the issues causing the linter to fail? I think this is ready to merge after....

lj365 commented 3 months ago

Can you fix the issues causing the linter to fail? I think this is ready to merge after....

Yes will do. Lots of these were not caught on previous pull requests, silently failing as it appears. Especially, the line-length > 80
https://github.com/cncf/tag-security/actions/runs/7575106912

The spelling checks are quite constraining to describe stuff technically as well

JustinCappos commented 3 months ago

Can you fix the issues causing the linter to fail? I think this is ready to merge after....

Yes will do. Lots of these were not caught on previous pull requests, silently failing as it appears. Especially, the line-length > 80 https://github.com/cncf/tag-security/actions/runs/7575106912

The spelling checks are quite constraining to describe stuff technically as well

For anything like the spell checker missing words, please just fix the actually wrong items and let me know. I'll either add the words to the spell checker or we will just skip that check...

lj365 commented 3 months ago

Can you fix the issues causing the linter to fail? I think this is ready to merge after....

Yes will do. Lots of these were not caught on previous pull requests, silently failing as it appears. Especially, the line-length > 80 https://github.com/cncf/tag-security/actions/runs/7575106912 The spelling checks are quite constraining to describe stuff technically as well

For anything like the spell checker missing words, please just fix the actually wrong items and let me know. I'll either add the words to the spell checker or we will just skip that check...

done that. The links check is failing because of the table of content, what's the right move here?

JustinCappos commented 3 months ago

Okay, thanks for the changes. I checked with the chairs and it is okay to change the linter to make this pass. I'll squash and merge this!