cncf / tag-security

🔐CNCF Security Technical Advisory Group -- secure access, policy control, privacy, auditing, explainability and more!
https://cncf.io/projects
Other
1.99k stars 496 forks source link

docs: Compliance Working Group details addition to security tag landing page #1238

Closed AleJo2995 closed 1 month ago

netlify[bot] commented 2 months ago

Deploy Preview for tag-security ready!

Name Link
Latest commit a338b5a9fd7fffa95fcd6d01a6c1edfbb4ed8405
Latest deploy log https://app.netlify.com/sites/tag-security/deploys/6633abef43eb640008982bbe
Deploy Preview https://deploy-preview-1238--tag-security.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

PushkarJ commented 2 months ago

Please hold as a few discussions are ongoing in preparation for merging this

AleJo2995 commented 2 months ago

@PushkarJ I have addressed all the coments above. Thanks 👍

PushkarJ commented 2 months ago

Thanks @AleJo2995 can you please fix the linting errors?

PushkarJ commented 2 months ago

I committed a couple of residual suggestions too.

AleJo2995 commented 2 months ago

mmm weird @PushkarJ , I just commited a couple of changes in compliance readme and then checks are not executed anymore 🤔 See the differences:

Failed checks

image

Current checks

image

The linters seem to not executing. Is this the workflow that needs approval?

AleJo2995 commented 2 months ago

Also, if you see Spelling check is complaining about names and last names? How should I fix this?

image
PushkarJ commented 2 months ago

I ran the checks for you now.

Try cspell enable and disable for ignoring names https://cspell.org/configuration/document-settings/

AleJo2995 commented 2 months ago

@PushkarJ I have made the changes for the first to checks to pass, but for the one with the links I am not being able to solve it. What I am curious about is why it is failing if I haven't changed anything there 😅

PushkarJ commented 2 months ago

You can ignore the links errors. Only three linting errors remaining :) after that we are good to go

AleJo2995 commented 1 month ago

@PushkarJ I have done the changes for the trailing spaces that were problematic. I think this is now good to go. Thanks 👍