Closed AleJo2995 closed 1 month ago
Please hold as a few discussions are ongoing in preparation for merging this
@PushkarJ I have addressed all the coments above. Thanks 👍
Thanks @AleJo2995 can you please fix the linting errors?
I committed a couple of residual suggestions too.
mmm weird @PushkarJ , I just commited a couple of changes in compliance readme and then checks are not executed anymore 🤔 See the differences:
Failed checks
Current checks
The linters seem to not executing. Is this the workflow that needs approval?
Also, if you see Spelling check is complaining about names and last names? How should I fix this?
I ran the checks for you now.
Try cspell enable and disable for ignoring names https://cspell.org/configuration/document-settings/
@PushkarJ I have made the changes for the first to checks to pass, but for the one with the links I am not being able to solve it. What I am curious about is why it is failing if I haven't changed anything there 😅
You can ignore the links errors. Only three linting errors remaining :) after that we are good to go
@PushkarJ I have done the changes for the trailing spaces that were problematic. I think this is now good to go. Thanks 👍
✅ Deploy Preview for tag-security ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.