Add Community to website navbar, add events to community as subfolder

mrcdb commented 1 week ago

This PR addresses open issues mentioned in https://github.com/cncf/tag-security/issues/1257 regarding the Events content that is currently conveyed on the TAG security website.

In particular, the PR:

enables the top-level community folder as a navbar item in the website in place of the existing events page, which is currently managed from website/content
creates a community/events subfolder in the repository
moves existing markdown files related to events to the community/events subfolder (also updating naming convention so they all show with hyphens on the website)
creates README.md files for community/ and community/events for improved website navigation experience
removes boilerplate community HTML layout

netlify[bot] commented 1 week ago

Deploy Preview for tag-security ready!

Name	Link
Latest commit	a012a1963dee1f426e1b262cf5840b7a3fdd07b9
Latest deploy log	https://app.netlify.com/sites/tag-security/deploys/6675bce687ec5200085e99f9
Deploy Preview	https://deploy-preview-1281--tag-security.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mrcdb commented 1 week ago

I have been trying to fix the linter links check but it looks like a couple of sched links keep returning 429 (too many requests), and I suspect its due to the large amount of links being tested in this PR. I can open the links fine from my laptop. Is there a workaround for that?

EDIT: fixed the issue by increasing retry times and number of retries on the links checker CI job

eddie-knight commented 1 week ago

Community as a navbar item feels appropriate in my opinion. The placement of events among a list of initiatives feels like something we can refine. (maybe we can nest the initiatives under a sub-directory?).

I like the idea. Stirs up more ideas about community structure... but I'll save those for later.

mrcdb commented 1 week ago

Community as a navbar item feels appropriate in my opinion. The placement of events among a list of initiatives feels like something we can refine. (maybe we can nest the initiatives under a sub-directory?).

@brandtkeller I thought the same when testing out the changes. Having the events page at the same level as each working group sounds a bit inconsistent, I'd second your idea of having a "working groups" folder that includes all the WGs collaterals as sub-folders. Happy to give a try at this in this PR.

eddie-knight commented 1 week ago

@brandtkeller I thought the same when testing out the changes. Having the events page at the same level as each working group sounds a bit inconsistent, I'd second your idea of having a "working groups" folder that includes all the WGs collaterals as sub-folders. Happy to give a try at this in this PR.

What if we modify the directories to have WG at the end of each? We could open this up for discussion as a followup item.

mrcdb commented 1 week ago

@brandtkeller I thought the same when testing out the changes. Having the events page at the same level as each working group sounds a bit inconsistent, I'd second your idea of having a "working groups" folder that includes all the WGs collaterals as sub-folders. Happy to give a try at this in this PR.

What if we modify the directories to have WG at the end of each? We could open this up for discussion as a followup item.

Appending -wg on each WG directory name will improve the clarity of the Community sidebar for sure

anvega commented 1 week ago

Dottore @mrcdb! Nice one.

To respond to @brandtkeller, I don't have strong thoughts on a final structure. It's all fluid, and we can continue to iterate until we arrive at what it should be for now, although the thinking is synchronized with #1283. As part of the lift there, I created an events directory and moved two of the three files. I removed the safe-kubecon.md as it was notes that, due to lack of context, don't mean much to new visitors. It probably still deserves an entry under past events but without the hyperlink to the markdown file.

If you have a look at this document, you can get a view of the current target structure of the repo org. I deliberately didn't contemplate website impact there, so I'll defer on that to you all. It hadn't really been part of the workflow on maintaining the repo until your work that is underway here.

As part of that first #1283, I also moved the workgroup subdirectories under a working-groups directory. There are a few more changes like moving assessments to community/resources and moving the Makefile and dockercompose.yml inside the CI folder and adjusting the Actions workflow, which I'm still working on. I should probably create individual issues and a milestone tracker for visibility for the rest of the work and for us to be in sync.

I didn't create markdown READMEs for community or its subdirectories, so this is a super welcome addition to fix that.

anvega commented 1 week ago

From a sequencing standpoint, we should probably review #1273 given its size, as merging this one first will result in conflicts that won't be easily resolved.

eddie-knight commented 1 week ago

@mrcdb I left a comment above— I don't think this PR is in a good state right now, but if we roll it back I'm happy to add a follow-up PR or commit with the changes needed to get the bloggy behavior in community/events

mrcdb commented 1 week ago

@mrcdb I left a comment above— I don't think this PR is in a good state right now, but if we roll it back I'm happy to add a follow-up PR or commit with the changes needed to get the bloggy behavior in community/events

Agree on that, I just rolled this back to the previous state. Happy for you to add a commit in the repo to get the desired behaviour for community/events (as I wasn't able to get that working without affecting other community pages unless I moved it to a top-level menu item)

cncf / tag-security