search

cncf / toc

⚖️ The CNCF Technical Oversight Committee (TOC) is the technical governing body of the CNCF Foundation.
https://cncf.io
1.68k stars 633 forks source link

Update tag network documents #1395

Closed devbird007 closed 2 months ago

devbird007 commented 3 months ago

This PR fixes cncf/tag-network#42

Along with work in TAG Network PR.

Hi @riaankleinhans, I'd like to complete the table for TAG Network in the tags/cncf-tags.md file, but I do not know how to get the Organization and Term of the TAG Network Chairs and Tech Lead.

riaankleinhans commented 3 months ago

@devbird007 thank you for the update. Here is some additional updated I would like you to do.

About the tags/cncf-tags.md file

The term & organization is not implemented by all TAGs, so it is OK to leave those fields blank. Please go ahead and add markdown tables around all the TAGs, same as you did for TAG Network.

About the TAG Network charter file

The change you made to the charter file is correct. Fixing the hyperlink and removing the leadership, meeting and contact information is inline with the issue.

Additionally, please look at this PR in the TAG Network repo tags/cncf-tags.md Ignore the changes from line 103 as you already removed that as discussed above. Bring over the changes in that PR and include it in this copy of the charter that you are working on. The aim is to delete the charting the the TAG Network repo once this copy of the chart is up to date.

When deleting the projects listed, replace the landscape hyperlink with this filtered link: https://landscape.cncf.io/?group=projects-and-products&view-mode=grid&tag=network

Thank you.

devbird007 commented 2 months ago

Hi @riaankleinhans, in your comment under About the TAG Network charter file. I notice you made a mistake in the PR you are linking in the TAG Network Repo, because when I click the link, it just loops right back to this PR.

Might this be the PR you actually wanted to reference: here.

If so, I will make the changes accordingly now.

riaankleinhans commented 2 months ago

Hi @riaankleinhans, in your comment under About the TAG Network charter file. I notice you made a mistake in the PR you are linking in the TAG Network Repo, because when I click the link, it just loops right back to this PR.

Might this be the PR you actually wanted to reference: here.

If so, I will make the changes accordingly now.

You are correct. Changes look good. I will leave it open for approval by the TAG Network leads and liaison.

riaankleinhans commented 2 months ago

/cc @nicholasjackson @ZackButcher @leecalcote

Can you please review and +1. This would also address #34 Next steps we would help update the TAG Network README and remove the duplicate copy of the charter in the TAG repo.