search

cncf / wordpress-site

📰🗞Repo for issues with cncf.io Wordpress site
Apache License 2.0
2 stars 5 forks source link

Add the Language filter for Speakers' page #111

Closed deigolocco closed 5 years ago

rodmeurer commented 5 years ago

@cjyabraham added language filtering: https://fz-111-cncf.pantheonsite.io/speakers/

KimMcMahon commented 5 years ago

I did some testing - works great.

This page is looking really good!

cjyabraham commented 5 years ago

@rodmeurer how will this look when the "Self-Identification" filter appears and what are the rules governing when that filter appears?

rodmeurer commented 5 years ago

@cjyabraham We haven't worked on it yet, but it will be minor adjustments to fit the fifth filter. Would you like us to test and tweak this before you deploy with the language filter or can we go back to this later after issue # 110 which is a priority for the week?

The rules when the filter appears follow the same pattern as the other filters, the quantities will be displayed according to the options that are selected in the other filters. It is hidden because there is no data for it yet.

cjyabraham commented 5 years ago

@rodmeurer cool. No, no need to worry about the "Self-Identification" filter for now. I was just concerned that it might appear automatically once people start filling out that field. If not, then we can leave it for now.

I have deployed this branch.

rodmeurer commented 5 years ago

@cjyabraham I asked to Danilo to test it locally and the filter automatically appears if you fill the self-identification field. So, we'll have to work on this to see how it fit in different displays and devices and adjust it.

image

cjyabraham commented 5 years ago

Ah. Can we get a fix for that quickly then so that we're not surprised with it appearing and make sure it looks good? Or, for now, we can just deactivate it?

cjyabraham commented 5 years ago

Thinking about it, I think it would be best to just deactivate it for now until we get a critical amount of data to make it useful to people. Can you do that @rodmeurer ?

rodmeurer commented 5 years ago

Yes @cjyabraham , already asked to Danilo to deactivate it for now. I'll let you know when it's ready to deploy again.

rodmeurer commented 5 years ago

@cjyabraham done, the filter will not be displayed. It's done in this same branch.

https://fz-111-cncf.pantheonsite.io/speakers/

cjyabraham commented 5 years ago

deployed