Get cel.dev/expr error with go get

cncf / xds

xDS API Working Group

Apache License 2.0

206 stars 72 forks source link

Closed zhangbc97 closed 7 months ago

zhangbc97 commented 12 months ago

After improt github.com/cncf/xds/go/xds/type/v3 , go get command get an error

go: main imports
        github.com/cncf/xds/go/xds/type/v3 imports
        cel.dev/expr: cannot find module providing package cel.dev/expr

main.go

package main

import (
        "github.com/cncf/xds/go/xds/type/v3"
)

go.mod

module main

go 1.21

LeVadim commented 12 months ago

Hello!

Same issue here:

Affecting spanner's DB Client

Best regards, Vadim

arhea commented 12 months ago

UPDATE: This is no longer needed as the change was rolled back until the domain settings are updated.

Temporary workaround:

replace github.com/cncf/xds => github.com/cncf/xds v0.0.0-20231116142803-3a472e524827

LeVadim commented 12 months ago

It worked, thank you! @arhea

adisuissa commented 12 months ago

@sergiitk I think it may be due to #75. Can you PTAL?

sergiitk commented 12 months ago

Yes, this is very likely due to #75. I'm not that familiar with the go ecosystem. I'll ask around.

sergiitk commented 12 months ago

@tristonianjones @l46kok Need your help here. Is package name cel.dev/expr incorrect?

l46kok commented 12 months ago

We're looking into this -- we'll need to setup a redirect to point at the github repo, then the import should just work. We'll keep you updated

sergiitk commented 11 months ago

FYI #75 was rolled back last week in #79, so the temporary pinning workaround https://github.com/cncf/xds/issues/76#issuecomment-1817646350 is not needed. I added CI verification job to prevent go build issues from happening again in #78.

Once CEL folks fix the domain settings, we'll bring back the CEL fields, see #81.

arhea commented 11 months ago

Updated my comment incase people don't scroll :)