search

cncf / xds

xDS API Working Group
Apache License 2.0
203 stars 70 forks source link

Go Bazel builds fail to find cel.dev/expr #97

Open sfc-gh-randerson opened 4 months ago

sfc-gh-randerson commented 4 months ago

In https://github.com/cncf/xds/pull/89 the cel.dev/expr based annotations were reintroduced. Unfortunately, there still seem to be issues when trying to use Bazel, Go and Gazelle together, and importing this module.

I've recently added a dependency on github.com/cncf/xds/go/xds/type/matcher/v3 and updated my dependency on go-control-plane to pick up a bugfix (https://github.com/envoyproxy/go-control-plane/commit/77feb56c98e5450a45be4715c868cca909873553 ).

(I'm not sure my new dependency there matters, tbh. It's just very close and maybe adding confusion.)

This update to go-control-plane updated the version to this library, and thus picked up the cel.dev/expr change.

Now, my builds fail with: ERROR: /private/var/tmp/_bazel_randerson/01ba2733315bf63f62b0e43c3a981a72/external/com_github_cncf_xds_go/xds/type/v3/BUILD.bazel:3:11: no such target '@dev_cel_expr//:expr': target 'expr' not declared in package '' defined by /private/var/tmp/_bazel_randerson/01ba2733315bf63f62b0e43c3a981a72/external/dev_cel_expr/BUILD.bazel (Tip: use query "@dev_cel_expr//:*" to see all the targets in that package) and referenced by '@com_github_cncf_xds_go//xds/type/v3:type'

The BUILD file there doesn't actually define any go libraries, so this isn't particularly surprising, but I don't think this commit is working as expected right now.

I'm not really sure if the problem is here or in cel.dev/expr, but ... well, debugging 3 layers of modules down is not fun.

aaomidi commented 2 months ago

Lets see if we can poke folks to go accept https://github.com/google/cel-spec/pull/379 and https://github.com/google/cel-spec/pull/354

derekperkins commented 1 month ago

Not sure if it's related, but I can't build with bazel in WORKSPACE mode after upgrading to a recent commit.

ERROR: no such package '@@com_github_cncf_xds_go//xds/annotations/v3': BUILD file not found in directory 'xds/annotations/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package.
ERROR: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package.
ERROR: no such package '@@com_github_cncf_xds_go//xds/core/v3': BUILD file not found in directory 'xds/core/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package.

ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/type/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/type/v3:type'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/type/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//xds/annotations/v3': BUILD file not found in directory 'xds/annotations/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/type/v3:type'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/type/matcher/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/type/matcher/v3:matcher'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/type/matcher/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//xds/core/v3': BUILD file not found in directory 'xds/core/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/type/matcher/v3:matcher'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/config/core/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/config/core/v3:core'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/config/core/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//xds/annotations/v3': BUILD file not found in directory 'xds/annotations/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/config/core/v3:core'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/config/core/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//xds/core/v3': BUILD file not found in directory 'xds/core/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/config/core/v3:core'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/service/auth/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/service/auth/v3:auth'