Fix a crash on destruction of qan::Navigatable

cneben / QuickQanava

:link: C++17 network / graph visualization library - Qt6 / QML node editor.

http://cneben.github.io/QuickQanava/index.html

Other

1.18k stars 230 forks source link

Fix a crash on destruction of qan::Navigatable #201

Closed emmenlau closed 11 months ago

emmenlau commented 1 year ago

When the destructor is called, it will change the child, which will trigger a signal to the parent. This can lead to a crash because the parent is in process of destruction.

emmenlau commented 1 year ago

Anyone?

cneben commented 1 year ago

Hi @emmenlau thank you very much for this (hard) one ! Will review it today and merge, sorry for late answer, too much work on non open-source work !

emmenlau commented 1 year ago

Awesome that you can appreciate it, two thumbs up from my side!