cnelsonakgov / serilog-sinks-azureapp

A Serilog sink that supports Azure App Services 'Diagnostics logs' and 'Log stream' features.
Creative Commons Zero v1.0 Universal
17 stars 2 forks source link

Standardize Versioning for NuGet #6

Closed cnelsonakgov closed 6 years ago

cnelsonakgov commented 6 years ago

Currently we are trying to match the release versions of Serilog.AspNetCore and Microsoft.Extensions.Logging.AzureAppServices which results in an additional build number beyond the 3 used by Semantic Versioning standard used by NuGet. Ex. Trying to build version for v2.1.1 get us v2.1.1.0 and v2.1.1.1.

NuGet suggests

version number in the form Major.Minor.Patch[-Suffix], where 
the components have the following meanings:

Major: Breaking changes
Minor: New features, but backwards compatible
Patch: Backwards compatible bug fixes only
-Suffix (optional): a hyphen followed by a string denoting a pre-release version

Looks like we need to change our release process to include a -pre-release suffix and/or stop trying to target the Patch releases of Serilog.AspNetCore and Microsoft.Extensions.Logging.AzureAppServices.

Suggestions from more experienced package developers are welcome!

cnelsonakgov commented 6 years ago

7 resolves this issue