search

cnerg / cnerg.github.com

CNERG Website
https://cnerg.github.io
MIT License
6 stars 60 forks source link

Add myself #211

Closed eitan-weinstein closed 1 year ago

eitan-weinstein commented 1 year ago

Thanks for this contribution @eitan-weinstein - I have a couple of comments on the files here. I think you'll also need to add yourself to the file _data/people.yml in the section that includes other undergraduates.

It's possible I did this wrong, but when I went back in to add myself into the people.yml file, it looked like my initial addition was successful and I was seeing my entry there. I put myself right after Gerson's entry.

eitan-weinstein commented 1 year ago

Thanks for this contribution @eitan-weinstein - I have a couple of comments on the files here. I think you'll also need to add yourself to the file _data/people.yml in the section that includes other undergraduates.

It's possible I did this wrong, but when I went back in to add myself into the people.yml file, it looked like my initial addition was successful and I was seeing my entry there. I put myself right after Gerson's entry.

Nevermind, I think I may have figured out the issue. I will submit another PR in a moment.

gonuke commented 1 year ago

This looks good now @eitan-weinstein! merging now