search

cnerg / cnerg.github.com

CNERG Website
https://cnerg.github.io
MIT License
6 stars 60 forks source link

Added Andrew Schumaker #230

Closed inquisitor-schumaker closed 9 months ago

inquisitor-schumaker commented 9 months ago

Added myself to the community folder.

MicahGale commented 9 months ago

I still need to test a build of this to see if anything is broken.

gonuke commented 9 months ago

This builds fine... I don't think any of the comments from @MicahGale are "blocking" - we can merge it as is - but I'll give you a chance to respond as you like.

Note: if you want to change anything, you can commit the changes to the same branch and github will automatically update the PR

MicahGale commented 9 months ago

I agree @gonuke, and thanks for doing the build because I deleted my build environment again.

inquisitor-schumaker commented 9 months ago

Changes per request

inquisitor-schumaker commented 9 months ago

Is the other line required? Whatever it was I removed I figured I didn't need since there was no useful information on it.

Respectfully,

Andrew Schumaker Office: ERB 443 Email: @.*** Campus ID: 9084958108

From: Paul Wilson @.> Sent: Sunday, December 10, 2023 5:08 PM To: cnerg/cnerg.github.com @.> Cc: Andrew Schumaker @.>; Author @.> Subject: Re: [cnerg/cnerg.github.com] Added Andrew Schumaker (PR #230)

@gonuke requested changes on this pull request.

Looks like you removed one line too many

In community/people/aps/index.mdhttps://github.com/cnerg/cnerg.github.com/pull/230#discussion_r1421834551:

@@ -0,0 +1,11 @@ +--- +layout: person +title: Andrew Schumaker +role: Graduate Student +image: Andrew_Github.jpg +email: @.*** +city_state_zip: "443 ERB, Madison, WI"

  • github: inquisitor-schumaker

Your last change took out this necessary line

⬇️ Suggested change

— Reply to this email directly, view it on GitHubhttps://github.com/cnerg/cnerg.github.com/pull/230#pullrequestreview-1774116462, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCDE5TTONCDQJXIX7D4RR2DYIY6GHAVCNFSM6AAAAABAH65UVWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZUGEYTMNBWGI. You are receiving this because you authored the thread.Message ID: @.***>