cnescatlab / sonar-cnes-report

Generates analysis reports from SonarQube web API.
GNU General Public License v3.0
425 stars 150 forks source link

support for 10.1.* version #365

Closed naveen12 closed 8 months ago

naveen12 commented 11 months ago

Hi Team,

first of all thanks to all contributors its a great tool, which produces result files from sonarqube community edition

may i know when you are planning to support 10.1.* version

rcfja commented 9 months ago

And now Sonarqube 10.2.* is out, which we would like to use this plugin on that.

ThalianSvk commented 9 months ago

Hello, my colleague Petr Mach and I have updated the compatibility with version sonarqube 10.x. It is necessary to modify pom.xml, api.js, AbstractDataProvider.java and AbstractQualityGateProvider.java. I am attaching the updated files in a zip folder. sonar-cnes-report-updated-files.zip

almas commented 9 months ago

Hello, my colleague Petr Mach and I have updated the compatibility with version sonarqube 10.x. It is necessary to modify pom.xml, api.js, AbstractDataProvider.java and AbstractQualityGateProvider.java. I am attaching the updated files in a zip folder. sonar-cnes-report-updated-files.zip

Can you create a pull request?

To contribute to a project on GitHub.com using the fork and pull request workflow, you need to follow these steps:

For more information and examples, you can refer to these resources:

(1) Creating a pull request from a fork - GitHub Docs. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork. (2) Contributing to projects - GitHub Docs. https://docs.github.com/en/get-started/quickstart/contributing-to-projects. (3) How To: Fork a GitHub Repository & Submit a Pull Request. https://bing.com/search?q=how+to+contribute+fork+and+pull+request+on+github.com. (4) Github’s Fork & Pull Workflow for Git Beginners - Reflectoring. https://reflectoring.io/github-fork-and-pull/. (5) github - Git - Creating pull request without forking - Stack Overflow. https://stackoverflow.com/questions/48110207/git-creating-pull-request-without-forking.

almas commented 9 months ago

Hello, my colleague Petr Mach and I have updated the compatibility with version sonarqube 10.x. It is necessary to modify pom.xml, api.js, AbstractDataProvider.java and AbstractQualityGateProvider.java. I am attaching the updated files in a zip folder. sonar-cnes-report-updated-files.zip

@ThalianSvk Thank you. I just little bit edited your code and created pull request.

louisjdmartin commented 8 months ago

Hi @naveen12 ,

As our ressources are limited, we only support LTS version of Sonarqube. So Sonarqube 10 support is planned for ... Sonarqube 10 LTS.

I see some contributors that purpose some workaround to make it work, I suggest you to check them, we will review and accept related pull request from @almas a litlle bit later. As explained on the Pull Request, on every major upgrades we have to review a lot of "underground" things (For every major release, SonarQube may changes API or internal behavior).

Thanks a lot for all your contribution.

I close this issue for now as upgrade is planned for Sonarqube 10 LTS

ZweiDM commented 8 months ago

For those who can't wait for another LTS: A temporary workaround is commenting out line 129 in ReportModelFactory.java.

change report.setQualityGate(qualityGateProvider.getProjectQualityGate()); to // report.setQualityGate(qualityGateProvider.getProjectQualityGate());

As a consequence, the name of the quality gate will be missing in the report, but the report generation doesn't crash.