cnescatlab / sonar-cnes-report

Generates analysis reports from SonarQube web API.
GNU General Public License v3.0
425 stars 150 forks source link

Added version 10.x support #368

Closed almas closed 2 months ago

almas commented 9 months ago

Added version 10.x support

Just little bit improved and added @ThalianSvk's version 10.x support. But I don't fully tested it by myself.

Types of changes

What types of changes does your code introduce to this software?

Put an x in the boxes that apply

Issues closed by changes

List here all issues closed by your changes. Use a list of items like - [x] Close #0

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

louisjdmartin commented 8 months ago

Thanks for your PR ! As we only support LTS version of sonarqube, we did not work on updates for SonarQube 10 yet. As sonarqube may change their API and some hidden stuff on major release, we can't merge it as-is, we should investigate impacts of such an update. But your PR is a starting point for us.

For example, CI throw this errors on tests:

expected<fr.cnes.sonar.report.exceptions.UnknownQualityGateException> but was<java.lang.NullPointerException>

Is this a behavior that as changed ? Is this a real NullPointerException ? We must investigate before merging :)

Pexers commented 5 months ago

+1 For SonarQube 10.x version support. 👍

Topin2001 commented 2 months ago

Thank you for this work, it help me create the MR #397 . I've create a new one because too many change have been made since your MR. Be aware that this MR is only a draft and might not work as intented. Thanks again