Confusingly takes directories as INPUT, not files

cneud / alto-tools

Python tools for performing various operations on ALTO XML files

Apache License 2.0

39 stars 15 forks source link

Confusingly takes directories as INPUT, not files #2

Closed mikegerber closed 5 years ago

mikegerber commented 5 years ago

The script confusingly takes only directories as INPUT, not files.

works: python3 alto_tools.py ~/devel/experiments/tesseract-fraktur/ --text

does NOT work: python3 alto_tools.py ~/devel/experiments/tesseract-fraktur/test-frak.xml --text

cneud commented 5 years ago

Yes, the whole i/o needs fixing or even better, a replacement with click. I had to abandon work on this due to other urgent business and never got round to fixing this. PR welcome ;-)

mikegerber commented 5 years ago

AFAICS, intended behaviour should be:

If an INPUT element is a file, read it
If an INPUT element is a directory, read all XML files in it, recursively

Is that correct?

cneud commented 5 years ago

@mikegerber Yes, that would have been the intention.