search

cnguy / kayn

superagent-inspired Node.js lib (w/ **some** TypeScript support) for accessing Riot's League of Legend's API (discord: cnguy#3614)
MIT License
135 stars 34 forks source link

v0.9.4 rate limiter may be broken #62

Open cnguy opened 5 years ago

cnguy commented 5 years ago

After integrating this, https://github.com/cnguy/kayn/issues/59, I did quick testing but didn't re-run all my examples to verify that the library still works properly. The hanging was solved, but batch promises don't seem to resolve via Promise.all.

For now stay on v0.9.3 or upgrade to v0.9.5 (they are the same things). v0.9.4 only introduces this hanging change.

What basically happens is the first promise of Promise.all will resolve, but the rest will not be resolved (in debug, the first request will be a success, while the rest are ignored, and then the process resolves).

For now I'll revert the change for v0.9.5 to prevent new install issues.

jamesaps commented 5 years ago

Any update on this?

cnguy commented 5 years ago

this will be revisited on the weekend