search

cnguy / onetricks.net

(WIP) kayn-powered (typescript node.js) ReasonReact app presenting you a dashboard of high ELO one trick ponies in League of Legends
http://onetricks.net
14 stars 2 forks source link

Adjust One Tricks Algorithm #11

Open cnguy opened 6 years ago

cnguy commented 6 years ago

Adjust the algorithm to scan the last 10-20 games to see if they're mostly playing the "one trick" champion they're normally playing (which they play for around >= 65% of their total games)

if so, add them else, they're moving on

cnguy commented 6 years ago

This would solve issues like this page breaking.

http://onetricks.net/champions/janna/history

This breaks because one of the one tricks have not played for a long time, and the 'algorithm' for match history picks up a match that doesn't have perks and so it breaks..

cnguy commented 6 years ago

this should be ez t o implement, lets goo.

let's get rid of useless data now

cnguy commented 6 years ago

https://github.com/cnguy/onetricks.net/commit/faed1b49381602505efdd6b50cce2a78f5f5da5d

This code (pre-comments, I commented it since there seemed to be bugs) in this commit was intended to solve this issue, but it seemed like it was not robust enough. This issue is a 'idk' and will probably depend on more research.