search

cnjinhao / nana

a modern C++ GUI library
https://nana.acemind.cn
Boost Software License 1.0
2.3k stars 331 forks source link

unify checkbox look #610

Closed StillGreen-san closed 3 years ago

StillGreen-san commented 3 years ago

Before - After (on Windows) 2021-02-08_14-18-48_nnp-test1 2021-02-08_14-18-57_checkbox

qPCR4vir commented 3 years ago

why?

StillGreen-san commented 3 years ago

For consistency and easier theming. And while it's probably possible to change the bitmaps to be affected by the color settings, I thought it was cleaner to have them generated in code.

qPCR4vir commented 3 years ago

yes, I agree, ... but is just not very pretty. Maybe there is a way to make them more beautiful? scalable? optional? sorry

StillGreen-san commented 3 years ago

If we are talking about the radio buttons (top right) then they could be made smaller, which also makes them rounder. But I'm not sure if that's better. 2021-02-08_19-52-39_checkbox

ErrorFlynn commented 3 years ago

In my opinion, the benefit of the proposed unified look is not worth it, because the new graphics are just too ugly in their current form (especially the radio buttons).

That being said, I do have a problem with the checkbox using bitmaps: the library always renders them at 16x16 pixels, regardless of the height of the text. That can be an issue when the desktop uses a high scaling factor, especially if the font size for the widget is larger than the default size. I might try to do something about that in the near future (I'm thinking to first try to draw them in an acceptable way somehow, and if that fails, stretching the bitmaps might be an option).