cnjon / react-native-pdf-view

React Native PDF View
MIT License
404 stars 167 forks source link

add prop-types as dependency for #90 #95

Closed Noitidart closed 6 years ago

Noitidart commented 6 years ago

Fixes #90

Noitidart commented 6 years ago

also closes #87

prscX commented 6 years ago

Hi @cnjon

Can you merge this PR, basically React as deprecated importing of PropTypes from react:

import React, {Component, PropTypes} from "react";

They have created a separate node module prop-type for the same:

import PropTypes from 'prop-types'

In ReactNative >=0.49.0 it is throwing exception due to which app is not working

Can you please approve this merge request, so that in next release onwards we can get the fix for the same

Please let me know in case any discussion is needed

Thanks Pranav

icaromag commented 6 years ago

Any updates on this merge?

prscX commented 6 years ago

Hi @cnjon, Can you please merge this PR. For each yarn install we are getting this error which is very annoyance.

Please let me know in case any discussion is required for the same.

Thanks Pranav

marcorm commented 6 years ago

Hi @cnjon, could you please merge this PR?

Thanks for your work! Marco

ue commented 6 years ago

I came here for adding the PropType 💃 🤣 Thanx for your work 👍

enieber commented 6 years ago

@sibelius you can merge this?

prscX commented 6 years ago

Thanks @sibelius for merging the PR 😄

Can you please publish the same on NPM as well.

Thanks </ Pranav >