search

cnlohr / ch32v003fun

Open source minimal stack for the ch32 line of WCH processors, including the ch32v003, a 10¢ 48 MHz RISC-V Microcontroller - as well as many other chips within the ch32v/x line.
MIT License
958 stars 146 forks source link

Improved comments, added millis() macro, made example main() more useful for systick_irq example #402

Closed ADBeta closed 1 month ago

ADBeta commented 1 month ago

I'm happy to do that to modernize it

ADBeta commented 1 month ago

Now uses funPinMode etc, tested to work the same

ADBeta commented 1 month ago

Typos are fixed

TommyMurphyTM1234 commented 1 month ago

Typos are fixed

I think I'm looking at the latest changes but still see typos... :-|

ADBeta commented 1 month ago

Double checked, fixed indents and one missing fix - Previous fixes were visible on the previous commit, not sure why you couldn't see them :thinking:

TommyMurphyTM1234 commented 1 month ago

Double checked, fixed indents and one missing fix - Previous fixes were visible on the previous commit, not sure why you couldn't see them 🤔

I don't understand - when I go into the PR and review the latest changes I still see this for example:

2024-09-25 17 34 26

ADBeta commented 1 month ago

Double checked, fixed indents and one missing fix - Previous fixes were visible on the previous commit, not sure why you couldn't see them 🤔

I don't understand - when I go into the PR and review the latest changes I still see this for example:

2024-09-25 17 34 26

I missed that one somehow.... I've fixed that one too now, should all be done :crossed_fingers: Let me know if you know of a good spellchecker plugin for nvim/vim lol

cnlohr commented 1 month ago

This all looks good to me now!