search

cnlohr / channel3

ESP8266 Analog Broadcast Television Interface
Other
1.33k stars 156 forks source link

Added PAL support #39

Closed schlarmann closed 1 year ago

schlarmann commented 1 year ago

Made some changes to the video timings to allow for PAL broadcasts. I didn't change the actual code for colour generation since I only wanted to use it with a B/W television.

Semi-Fixes #14

cnlohr commented 1 year ago

@schlarmann , This is extremely cool, but this looks like if merged would break NTSC, since some of the buffers aren't guarded behind -DPAL flags. Especially surrounding the tablemaker, etc. Can you add the extra guarding to make it be able to produce either PAL or NTSC?

schlarmann commented 1 year ago

Sorry for the radio silence the last months, I was busy with university stuff. Now the tablemaker.c generates both tables (for NTSC and PAL) so switching between them can be done completely with -DPAL. With my multisync (PAL / SECAM) TV I can now receive both broadcasts (in black and white), so I think I didn't break NTSC with this change, but this should probably be checked with an actual NTSC TV before merging.

cnlohr commented 1 year ago

Can you try squashing all of your commits? I really can't figure out what exactly is going on here, but it looks like you changed much more than you intended, @schlarmann.

https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/managing-commits/squashing-commits

schlarmann commented 1 year ago

Like this? Sorry for the confusion, I just noticed after pushing that I forgot to update the README with new documentation and to set up the user.cfg to build NTSC by default so I made the 2 other commits to correct for this.

cnlohr commented 1 year ago

YESS LIKE THAT! I will review soon.

cnlohr commented 1 year ago

YES! This is beautiful 🧑‍🍳😙🤌