Open CaiB opened 3 years ago
While porting Voronoi over to ColorChord.NET, I found some bugs:
A lot of the config files define shape_cutoff, but this does not seem to get used. Instead, the voronoi output is looking for Voronoi_cutoff: https://github.com/cnlohr/colorchord/blob/master/colorchord2/OutputVoronoi.c#L148
shape_cutoff
Voronoi_cutoff
This line makes no sense: https://github.com/cnlohr/colorchord/blob/master/colorchord2/OutputVoronoi.c#L115 I think you meant to do dist = powf(distsq, 1.0 / d->distpow); The default config uses a distpow value of 1.5.
dist = powf(distsq, 1.0 / d->distpow);
distpow
Line 15 defines MAX_LEDS_PER_NOTE, but this is never used.
Furthermore, the lednrm in the LINote struct is assigned to but never read.
lednrm
LINote
@CaiB do you mind doing a PR for this, you are correct.
While porting Voronoi over to ColorChord.NET, I found some bugs:
A lot of the config files define
shape_cutoff
, but this does not seem to get used. Instead, the voronoi output is looking forVoronoi_cutoff
: https://github.com/cnlohr/colorchord/blob/master/colorchord2/OutputVoronoi.c#L148This line makes no sense: https://github.com/cnlohr/colorchord/blob/master/colorchord2/OutputVoronoi.c#L115 I think you meant to do
dist = powf(distsq, 1.0 / d->distpow);
The default config uses adistpow
value of 1.5.Line 15 defines MAX_LEDS_PER_NOTE, but this is never used.
Furthermore, the
lednrm
in theLINote
struct is assigned to but never read.