work in bbkiwi's work.

[cnlohr]

@bbkiwi You've done a ton of work here, but there's some that I just don't feel is the right thing to put back into mainline. I like some of the features you've added. I'm rather surprised they don't come at an IRAM cost.

We can discuss some of the changes that we would want to bring into mainline here.

[cnlohr]

@king2 writes:

@cnlohr, I can add only one thing: we have added some debugging code that executed after reboot and allows to know where it was crashed. SDK when crashing writes info about crash into RTC mem (that's because we are getting such messages about don't use rtc mem!) We have checked 3 times, every time crash was associated with executing read_sar_dout function, with reason 'invalid command', and possible cause as 'invalid binaries' or 'wild pointers'.

I didn't look at that, but as soon as I disabled the SAR while it was negotiating the connection, everything was fine. Something changed in the SDK more recently which jams it up the whole thing when it's connecting to a WPA2 network. I think there's some sort of issue with interrupts in that case which kinda trainwrecks stuff. In my changes, just by pausing the SAR until connection is complete seems to solve it.

[bbkiwi]

The additions to cc/embeded come at a memory cost. Looking forward to trying this new commit and then seeing if my changes will fit.

[bbkiwi]

A thank you gift for @king2 https://youtu.be/SsxNKp0NxNI Another https://youtu.be/qNqZZR944xM

@cnlohr I am making progress of incorporating my changes to your latest commit.

[cnlohr]

Dude. I really need to stop disappearing from social communities completely for long periods of time.

Just wondering did you get the # of leds right as the setting? It looks like you only have a subset visible.

[bbkiwi]

Hi Charles,

The number of LEDs is ok in video however I was using one of my added display options that only shows an arc of fewer LEDs which moves in response to peak beats - also the angle of the video hid the LEDs on top of the banjo.

Stability, clean scope, center value and range of the ADC seem to be a feature both of the software AND electronic components. Using an Adafruit mic is made stable using a simple low pass filter on its power and various software options while using a banggood mic needs other software options.

I wanted to be able to specify a static IP so Ive needed to create a branch of esp82xx to allow this. Also there was a colorchord issue that I was only able to fix by adding code to esp82xx.

Currently I have on my fork of colorchord a branch adddevwork which store parameters via your method using CCSetting structure and adds all my improvements. Ive also added options to user.cfg to specify different stability options. It uses the modified esp82xx module which is on an early commit on my branch tmp (esp82xx@fc455).

Ive been mainly working on branch newfeatures which is using the current head of my branch tmp (esp82xx@163d47). Most of the later commits on tmp are to improve the version reporting in the gui. I have so many nodemcu boards and branches on my colorchord and esp82xx that I wanted to know about which commits and what dirty files were being used. The web page gui now links to a file dirtyinfo.html which gives git info and diffs.

Cheers, Bill

[cnlohr]

I am still digging through your previous PR, and there is a fair bit I really /can't/ add. Things like setting all the places with USE_NUM_LIN_LEDS to NUM_LIN_LEDS, and stuff like that. I am really intriuged by some of your optimization things you mentioned but I don't really know how to pull them apart from the rest of it.

Are these other branches you are referencing... have they been pulling stuff from the current trunk? Or still building on the old stuff?

literally TODAY I found out about the mic thing. I don't understand why high-frequency interference does what it does to the mic, but, a 2.2nF capacitor fixes EVERYTHING. It's amazing now.

[cnlohr]

Man I want that wraparound code in my stuff... also that sort stuff looks super swanky!

[bbkiwi]

When Im back home I can look further. Keen to see you mic wiring. My branch started with your master at commit ed9ac July 19

[cnlohr]

Audio in is a jack in case you want to accept audio another way.