search

cnlohr / esp82xx

Useful ESP8266 C Environment
Other
288 stars 107 forks source link

Fix failed OTA update via web #62

Closed king2 closed 7 years ago

king2 commented 7 years ago
  1. removed skipping one byte from firmware sent by web
  2. corrected assign of nibbles (now it will work correctly with any optimization level)
cnlohr commented 7 years ago

This says it's against 'master' please make the PR against 'dev' instead. You will also need to see what @con-f-use did so far :-p. Keep going, this is very close to the right thing!

king2 commented 7 years ago

Ohhhh, you are forcing bad old me to forget about balalaika, vodka and my own bear and to start making changes in things that I not completely understand :)

I made pull request for both cases to dev. Was my new try more succesful than first? :)

con-f-use commented 7 years ago

So this will be propagated from your other (now merged) pull request #63 to the dev branch, once verified. The commit was adb21e5.

Btw., I just found out one can switch the target branch of a pull request. Apparently github added this feature, while I wasn't looking.

switch base branch