search

cnlohr / rawdrawandroid

Build android apps without any java, entirely in C and Make
MIT License
3.55k stars 226 forks source link

package="${PACKAGENAME}" is left in AndroidManifest.xml #31

Closed MobiusHorizons closed 4 years ago

MobiusHorizons commented 4 years ago

Following the instructions I ran 

make push run

after which I saw the following error message:

AndroidManifest.xml:2: Tag <manifest> attribute package has invalid character '$'.

It looks like a variable package="${PACKAGENAME}" was left un-replaced from the template.

looking at the Makefile:

    envsubst '$$ANDROIDTARGET $$ANDROIDVERSION $$APPNAME $$LABEL' \
        < AndroidManifest.xml.template > AndroidManifest.xml

it doesn't look like the package name is added for substitution.

MobiusHorizons commented 4 years ago

Update: I updated the line in the Makefile to specify the PROJECTNAME variable, but then I noticed that all the variables were getting written into the file as blanks (eg projectname=""). I don't know why this is, since it seems like the variables were getting exported correctly. I edited the file manually and it worked, but 

make -B AndroidManifest.xml

results in a broken manifest.

cnlohr commented 4 years ago

Do you have a github project I could try to pull and try out and see what's going on with?

MobiusHorizons commented 4 years ago

This was just after checking out the repo with no other modifications.

cnlohr commented 4 years ago

herp derp.... ok I think I see the issue.