search

cnlohr / rawdrawandroid

Build android apps without any java, entirely in C and Make
MIT License
2.75k stars 197 forks source link

Remove jarsigner #57

Closed DavidVentura closed 1 year ago

DavidVentura commented 1 year ago

Seems unnecessary and adds ~280ms to build time, on my machine, taking the mean of 5 builds:

Oldes commented 1 year ago

IMHO, maybe you don't need signed APK, but others may need it. As this project is (as I understand) an example, how can be things done, it is not good to remove parts of it just because you need to save 300ms of your valuable time. Imagine that someone could spend hours to find out, how to sign an APK, just because of this change.

DavidVentura commented 1 year ago

That's alright - however, the APK is still signed. With the current method it's signed twice, and apksign is both required and sufficient since SDK ver 30

Oldes commented 1 year ago

The decision is not up to me... I just think that removing code just like that is not good. You can always just comment it out and add a comment which explains, why the line was there and why you think it is not required anymore.

And btw.. I am not sure that everybody targets SDK30 and newer with projects like this one.

cnlohr commented 1 year ago

hnngggg I just don't know the right answer here. I don't have experience releasing things to the Play store recently. I am curious which Android SDK versions can be released without it to the Android store.

DavidVentura commented 1 year ago

The docs specify that signature v2 is supported since Android 7 (2016). If you target anything before that, it must be signed with jarsigner.

cnlohr commented 1 year ago

There are people who use this project for anciieent version of Android.

I am willing to have the default to not use jarsigner, but we have to have a note there for the bredcrumbs for the people who are still using this with Android 5 and earlier.

We can put an inline # and comment notifying people that if they are on really old versions of android, they don't need it.