search

cnlohr / rawdrawandroid

Build android apps without any java, entirely in C and Make
MIT License
2.75k stars 197 forks source link

Fix #21: Do not render anything if the window has been terminated #63

Closed DavidVentura closed 4 months ago

DavidVentura commented 1 year ago

This change depends on https://github.com/cntools/rawdraw/pull/100 and is only here for completion's sake -- HandleWindowTermination would be come required.

Updating the rawdraw submodule is necessary for this change to do anything.

cnlohr commented 1 year ago

Should we instead just call pause on this event?

I am just anxious making users add yet another required function.

DavidVentura commented 1 year ago

I don't have an opinion on it -- a termination is different, as the resources could/should be freed.

Maybe all events should be handled with HandleEvent(Event e) or something along those lines.

If you prefer to stay with HandleSuspend as the handler for this event, feel free to close this PR

cnlohr commented 10 months ago

OH sheesh, sorry just noticing this now - interesting I ran into the same issue and solved it in a really terrible way. This would be a much better way to do it.