ghost
commented
8 years ago @MDrooker: @adslaton and I talked about this and agreed to revisit the general design, this commit just aims to make these two options available to assist in adoption.
I think the general answer to "why wouldn't this come from passed in options" would be the same reason you'd have a default anywhere: to promote ease of use by reducing the amount of wiring necessary to get started.
I think we'd want to look at three things going forward:
- Should cnn-hapi negotiate environment variables (et al) or should that responsibility be held somewhere else? (perhaps this is what you were getting at?)
- What should the precedence of these configuration variables be? My view was that passed-in should trump environment, but that might not be our convention. (moving that responsibility moves, but does not eliminate that question)
- To what extent should we provide direct access to Hapi configurations and events and how do we best combine that with the niceties that come from an easy, out-of-the-box experience?
(I'll zap the package version)
adslaton
This:
:)