search

cnnlabs / cnn-hapi

CNN Hapi
10 stars 4 forks source link

Feature/v1.0.0 #38

Closed codeclout closed 8 years ago

codeclout commented 8 years ago

same as feature/v0.13.0 major bump due to all updates not being backward compatible

hhamilton-turner commented 8 years ago

I sat with @codeclout , and he explained the changes to me. Approved.

@codeclout Minor: Need new lines at the end of some of the files. Github points out which ones specifically.

adslaton commented 8 years ago

All the changes are good and work as I expect.

I am not convinced on the about the environment variable to being overridden by passed in options. This violates rule 3 of having 12 factor applications. See https://12factor.net/config.

I believe in order for this to move forward, the order should be changed to give priority over environment values.