Codecov Report

Merging #101 into master will increase coverage by 0.05%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   92.91%   92.96%   +0.05%     
==========================================
  Files          38       38              
  Lines        1340     1350      +10     
==========================================
+ Hits         1245     1255      +10     
  Misses         95       95

Impacted Files	Coverage Δ
config/config.default.js	`100% <ø> (ø)`	:arrow_up:
app/extend/helper.js	`93.18% <ø> (+8.56%)`	:arrow_up:
app/router.js	`98.36% <100%> (+0.02%)`	:arrow_up:
app/service/topic.js	`80.26% <6.25%> (-19.74%)`	:arrow_down:
app/controller/topic.js	`95.95% <85.71%> (+5.09%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 782c164...810fedf. Read the comment docs.

JacksonTian commented 6 years ago

测试挂了。

thonatos commented 6 years ago

感觉封一个插件更好，维护也方便~

JacksonTian commented 6 years ago

测试挂了没人修啊

thonatos commented 6 years ago

@nanzm 这边推进一下呗

nanzm commented 6 years ago

topic service里的七牛上传不知道怎么写测试没有公用的 AK SK

EryouHao commented 6 years ago

我说看了半天代码，看着上传就有问题，果然有人 PR 了，😄

atian25 commented 6 years ago

@nanzm 修复下？

或者 @EryouHao 你也可以新 PR 修复

nanzm commented 6 years ago

啊啊啊啊啊这个测试我要疯了覆盖率不够吗

cnodejs / egg-cnode

fix: upload file #101

Checklist

Affected core subsystem(s)

Description of change

Codecov Report