Closed ghost closed 6 years ago
Merging #139 into master will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 93.26% 93.27% +<.01%
==========================================
Files 48 48
Lines 1664 1665 +1
==========================================
+ Hits 1552 1553 +1
Misses 112 112
Impacted Files | Coverage Δ | |
---|---|---|
app/controller/api/message.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e634a68...f4db0dd. Read the comment docs.
/cc: @JacksonTian
1) Use
ES6
syntax to rewritereadMessages
/unreadMessages
instead of using index for a whole array. 2) Use Promise.all to wrap the mapping from read/unread messages and do Promise.all to await to save time.npm test
passes